Skip to content

Conversation

botantony
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Shortly after the release of Bun 1.3.0, I tried to build this thing without vendored dependencies yet again. Unfortunately, this wasn't successful at all. I do not like the result as it goes against the Homebrew approach but at least it works (and I guess this is when we can make an exception)

Disabling new formula checks as it requires newer ruby and libiconv. For some reason the audit complains about the resource URL (even after adding it to binary_bootstrap_formula_urls_allowlist.json)

@Copilot Copilot AI review requested due to automatic review settings October 19, 2025 21:07
@botantony botantony added maintainer feedback Additional maintainers' opinions may be needed CI-skip-new-formulae Pass --skip-new to brew test-bot. CI-skip-new-formulae-strict Pass --skip-new-strict to brew test-bot. labels Oct 19, 2025
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core labels Oct 19, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new Homebrew formula for Bun 1.3.0, a JavaScript runtime, bundler, test runner, and package manager. The formula uses vendored dependencies and requires a bootstrap binary to build, which is a deviation from typical Homebrew practices but necessary due to build complexity.

Key Changes:

  • New formula for Bun 1.3.0 with comprehensive build dependencies
  • Bootstrap binary resources for multiple platforms (macOS/Linux, ARM/Intel)
  • Allowlist entry for binary bootstrap URLs to pass style checks

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Formula/b/bun.rb New formula defining Bun package with build dependencies, bootstrap resources, and installation/test logic
style_exceptions/binary_bootstrap_formula_urls_allowlist.json Adds "bun" to allowlist for binary bootstrap URLs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@botantony botantony force-pushed the bun-new-formula branch 2 times, most recently from 5bcaf91 to f7be44a Compare October 19, 2025 21:28
@botantony botantony added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Oct 19, 2025
@botantony botantony marked this pull request as draft October 19, 2025 22:54
Signed-off-by: botantony <antonsm21@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge-skip `brew pr-automerge` will skip this pull request CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-new-formulae Pass --skip-new to brew test-bot. CI-skip-new-formulae-strict Pass --skip-new-strict to brew test-bot. maintainer feedback Additional maintainers' opinions may be needed new formula PR adds a new formula to Homebrew/homebrew-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant